[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] xc_console is probably too chatty about termios failures since ssh



# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID f5a5e61f038ef7a4eb9180be94cbaba2487822a6
# Parent  38e6467df0e6116f7ea97ee77bf58a30a9dd70d6
xc_console is probably too chatty about termios failures since ssh 
sessions apparently don't have proper term settings.

Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>

diff -r 38e6467df0e6 -r f5a5e61f038e tools/consoled/xc_console.c
--- a/tools/consoled/xc_console.c       Fri Aug  5 08:59:41 2005
+++ b/tools/consoled/xc_console.c       Fri Aug  5 09:00:50 2005
@@ -78,23 +78,18 @@
        struct termios new_term;
 
        if (tcgetattr(fd, old) == -1) {
-               perror("tcgetattr() failed");
                return;
        }
 
        new_term = *old;
        cfmakeraw(&new_term);
 
-       if (tcsetattr(fd, TCSAFLUSH, &new_term) == -1) {
-               perror("tcsetattr() failed");
-       }
+       tcsetattr(fd, TCSAFLUSH, &new_term);
 }
 
 static void restore_term(int fd, struct termios *old)
 {
-       if (tcsetattr(fd, TCSAFLUSH, old) == -1) {
-               perror("tcsetattr() failed");
-       }
+       tcsetattr(fd, TCSAFLUSH, old);
 }
 
 static int console_loop(int xc_handle, domid_t domid, int fd)
@@ -113,7 +108,6 @@
                        if (errno == EINTR || errno == EAGAIN) {
                                continue;
                        }
-                       perror("select() failed");
                        return -1;
                }
 
@@ -131,7 +125,6 @@
                                    (errno == EINTR || errno == EAGAIN)) {
                                        continue;
                                }
-                               perror("select() failed");
                                return -1;
                        }
 
@@ -151,7 +144,6 @@
                                    (errno == EINTR || errno == EAGAIN)) {
                                        continue;
                                }
-                               perror("select() failed");
                                return -1;
                        }
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.