[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] 1. Remove workaround patch
# HG changeset patch # User kaf24@xxxxxxxxxxxxxxxxxxxx # Node ID d61f8afd292c146a08b8047f95941bcd9477d504 # Parent 37030498b9782169fccc14b064daf83714557c8d 1. Remove workaround patch 2. Update scripts/vif-bridge to not call 'brctl delif' When a domU is shutdown/destroyed and the netif is destroyed, the notify_call_chain triggered from unregister_netdevice() will trigger the bridge event handler and which will call the proper code to remove the device from the bridge. I can't see any reason why brtcl delif should be called when taking out a domain if the call chain will delete the interface from the bridge when the vif is destroyed automatically. Signed-off-by: Ryan Harper <ryanh@xxxxxxxxxx> diff -r 37030498b978 -r d61f8afd292c tools/examples/vif-bridge --- a/tools/examples/vif-bridge Thu Aug 25 14:58:20 2005 +++ b/tools/examples/vif-bridge Thu Aug 25 15:51:30 2005 @@ -74,8 +74,10 @@ exit fi -# Add/remove vif to/from bridge. -brctl ${brcmd} ${bridge} ${vif} +# Add vif to bridge. vifs are auto-removed from bridge. +if [ "${brcmd}" == "addif" ] ; then + brctl ${brcmd} ${bridge} ${vif} +fi ifconfig ${vif} $OP if [ ${ip} ] ; then diff -r 37030498b978 -r d61f8afd292c patches/linux-2.6.12/workaround_double_br_del_if.patch --- a/patches/linux-2.6.12/workaround_double_br_del_if.patch Thu Aug 25 14:58:20 2005 +++ /dev/null Thu Aug 25 15:51:30 2005 @@ -1,11 +0,0 @@ ---- linux-2.6.12/net/bridge/br_if.c 2005-06-17 14:48:29.000000000 -0500 -+++ linux-2.6.12-xen0-smp/net/bridge/br_if.c 2005-08-18 15:17:27.302615846 -0500 -@@ -382,7 +382,7 @@ - { - struct net_bridge_port *p = dev->br_port; - -- if (!p || p->br != br) -+ if (!p || p->br != br || p->state == BR_STATE_DISABLED) - return -EINVAL; - - br_sysfs_removeif(p); _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |