[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] Yes, that fixes the problem, our patches crossed. I saw Keir already



# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID 4508c22dc45839721807753c373916c6601d74e9
# Parent  5721657e8130ac601eec7ae192e67f45e37f1125
Yes, that fixes the problem, our patches crossed. I saw Keir already
integrated my patch and while it is harmless, it is redundant and
here is the diff to take it out.

The patch also addresses some indent problems and aligns instructions
up with the rest of the block.

Signed-Off-By: Leendert van Doorn <leendert@xxxxxxxxxxxxxx>

diff -r 5721657e8130 -r 4508c22dc458 xen/arch/x86/vmx_io.c
--- a/xen/arch/x86/vmx_io.c     Sun Sep 11 16:34:38 2005
+++ b/xen/arch/x86/vmx_io.c     Sun Sep 11 16:36:24 2005
@@ -198,7 +198,6 @@
 static inline void __set_reg_value(unsigned long *reg, int size, long value)
 {
     switch (size) {
-        case BYTE:
         case BYTE_64:
             *reg &= ~0xFF;
             *reg |= (value & 0xFF);
diff -r 5721657e8130 -r 4508c22dc458 xen/arch/x86/vmx_platform.c
--- a/xen/arch/x86/vmx_platform.c       Sun Sep 11 16:34:38 2005
+++ b/xen/arch/x86/vmx_platform.c       Sun Sep 11 16:36:24 2005
@@ -55,7 +55,6 @@
 static inline long __get_reg_value(unsigned long reg, int size)
 {
     switch(size) {
-        case BYTE:
         case BYTE_64:
             return (char)(reg & 0xFF);
         case WORD:
@@ -90,10 +89,11 @@
                 return (char)((regs->rdx & 0xFF00) >> 8);
        case 7: /* %bh */
                 return (char)((regs->rbx & 0xFF00) >> 8);
-            default:
+       default:
            printf("Error: (get_reg_value) Invalid index value\n"); 
-                domain_crash_synchronous();
+           domain_crash_synchronous();
         }
+       /* NOTREACHED */
     }
 
     switch (index) {
@@ -114,8 +114,8 @@
         case 14: return __get_reg_value(regs->r14, size);
         case 15: return __get_reg_value(regs->r15, size);
         default:
-       printf("Error: (get_reg_value) Invalid index value\n"); 
-            domain_crash_synchronous();
+           printf("Error: (get_reg_value) Invalid index value\n"); 
+           domain_crash_synchronous();
     }
 }
 #elif defined (__i386__)

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.