[Xen-changelog] Some more resilience to errors in creating vbds etc; still needs more work

[Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User shand@xxxxxxxxxxxxxxxxxxxxxxxxxxx
# Node ID fe5b84a24d43cc0f4726be16402e31538edb3a20
# Parent  22d08cc7f739de5cb437ac25a9d7be1e894dfd98
Some more resilience to errors in creating vbds etc; still needs more work
to tidy up things properly (e.g. the store state). 

Signed-off-by: Steven Hand <steven@xxxxxxxxxxxxx>

diff -r 22d08cc7f739 -r fe5b84a24d43 
linux-2.6-xen-sparse/drivers/xen/blkback/xenbus.c
--- a/linux-2.6-xen-sparse/drivers/xen/blkback/xenbus.c Tue Sep 13 17:49:38 2005
+++ b/linux-2.6-xen-sparse/drivers/xen/blkback/xenbus.c Tue Sep 13 18:03:04 2005
@@ -170,6 +170,7 @@
 
                be->blkif = alloc_blkif(be->frontend_id);
                if (IS_ERR(be->blkif)) {
+                        /* XXX SMH: should free blkif here... hmm */
                        err = PTR_ERR(be->blkif);
                        be->blkif = NULL;
                        xenbus_dev_error(dev, err, "creating block interface");
@@ -178,6 +179,8 @@
 
                err = vbd_create(be->blkif, handle, be->pdev, be->readonly);
                if (err) {
+                        /* XXX SMH: should free blkif here too... */
+                        be->blkif = NULL; 
                        xenbus_dev_error(dev, err, "creating vbd structure");
                        return;
                }

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog