[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] Silenty ignore calls to xen_create_contiguous_region() when running



# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID ef31d088adeb7b7f203fba70ef91542019064706
# Parent  0349fb4de335eb7497f8d33107b83fd73291e441
Silenty ignore calls to xen_create_contiguous_region() when running
in auto_translated_physmap mode. A new comment in that function explains
why this is an okay thing to do.

This avoids an unnecessary crash in Xen's skbuff_ctor.

Signed-off-by: Michael Vrable <mvrable@xxxxxxxxxxx>
Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>

diff -r 0349fb4de335 -r ef31d088adeb 
linux-2.6-xen-sparse/arch/i386/mm/hypervisor.c
--- a/linux-2.6-xen-sparse/arch/i386/mm/hypervisor.c    Thu Feb 23 10:34:11 2006
+++ b/linux-2.6-xen-sparse/arch/i386/mm/hypervisor.c    Thu Feb 23 10:42:19 2006
@@ -324,10 +324,13 @@
                .domid        = DOMID_SELF
        };
 
-       if (xen_feature(XENFEAT_auto_translated_physmap)) {
-               BUG_ON(order >= 1);
+       /*
+        * Currently an auto-translated guest will not perform I/O, nor will
+        * it require PAE page directories below 4GB. Therefore any calls to
+        * this function are redundant and can be ignored.
+        */
+       if (xen_feature(XENFEAT_auto_translated_physmap))
                return 0;
-       }
 
        scrub_pages(vstart, 1 << order);
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.