[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] Fix a few small issues in xc_domain_dumpcore:



# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID e31f21fc391df06e74685ad59c4943370fa6b3f5
# Parent  85b34394c9a2fe8a41e77496bf32821053c995cb
Fix a few small issues in xc_domain_dumpcore:

xc_domain_getinfo returns information about a domain, but not
necessarily the one you asked about.  Add check for this.

max_vcpu_id in xc_domain_getinfo is really an ID, not a count, so
make the loop include the last VCPU

Signed-off-by: Ben Thomas <ben@xxxxxxxxxxxxxxx>

diff -r 85b34394c9a2 -r e31f21fc391d tools/libxc/xc_core.c
--- a/tools/libxc/xc_core.c     Thu Mar  9 21:31:45 2006
+++ b/tools/libxc/xc_core.c     Thu Mar  9 22:07:27 2006
@@ -54,9 +54,14 @@
         goto error_out;
     }
  
-    for (i = 0; i < info.max_vcpu_id; i++)
+    if (domid != info.domid) {
+        PERROR("Domain %d does not exist", domid);
+        goto error_out;
+    }
+
+    for (i = 0; i <= info.max_vcpu_id; i++)
         if (xc_vcpu_getcontext(xc_handle, domid,
-                                       i, &ctxt[nr_vcpus]) == 0)
+                               i, &ctxt[nr_vcpus]) == 0)
             nr_vcpus++;
  
     nr_pages = info.nr_pages;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.