[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen-unstable] [HVM][SVM] Don't BUG when VMRUN exitcode==-1, just crash the domain.
# HG changeset patch # User kaf24@xxxxxxxxxxxxxxxxxxxx # Node ID 784961057338c1313e416a9f0496939693241902 # Parent 86cae321e70789a19c74722cfff866d7268f252c [HVM][SVM] Don't BUG when VMRUN exitcode==-1, just crash the domain. If there's any consistency problems in the VMCB, the VMRUN will return an exitcode of -1 to indicate that the guest-state is "bad". Prior to this change, it would cause the hypervisor to reboot. This is not at all necessary - the VMCB may be bad, but the system is most likely still intact. [In particular, a guest could cause a crash of the system by setting up PAE with an invalid set of PDPE's, which is definitely not a desired behaviour] Now also print out the VMCB, as that MAY help identify the cause of the exitcode of -1. Signed-off-by: Mats Petersson <mats.petersson@xxxxxxx> --- xen/arch/x86/hvm/svm/svm.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -r 86cae321e707 -r 784961057338 xen/arch/x86/hvm/svm/svm.c --- a/xen/arch/x86/hvm/svm/svm.c Fri Jun 30 10:10:39 2006 +0100 +++ b/xen/arch/x86/hvm/svm/svm.c Fri Jun 30 10:13:17 2006 +0100 @@ -2697,9 +2697,9 @@ asmlinkage void svm_vmexit_handler(struc if (exit_reason == -1) { + svm_dump_vmcb(__func__, vmcb); printk("%s: exit_reason == -1 - Did someone clobber the VMCB\n", __func__); - BUG(); domain_crash_synchronous(); } _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |