[Xen-changelog] [xen-unstable] [XEN][POWERPC] cleanup for (;;);

[Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
# Node ID 030a041bbe90bf1483bf56a19ad6e8c587e5fe12
# Parent  3e144748d36f7bd4e1735f9c2434b5ef33961859
[XEN][POWERPC] cleanup for (;;);

When the port first started, we didn't even have panic() working
properly so we used "for(;;);" loops to stop execution.  Now that output
is buffered these look like hangs, since you usually do not see the
printk() before.

Signed-off-by: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Signed-off-by: Hollis Blanchard <hollisb@xxxxxxxxxx>
---
 xen/arch/powerpc/dart_u3.c  |    8 ++++----
 xen/arch/powerpc/external.c |    3 +--
 xen/arch/powerpc/papr/tce.c |    6 +++---
 3 files changed, 8 insertions(+), 9 deletions(-)

diff -r 3e144748d36f -r 030a041bbe90 xen/arch/powerpc/dart_u3.c
--- a/xen/arch/powerpc/dart_u3.c        Mon Aug 28 17:28:55 2006 -0400
+++ b/xen/arch/powerpc/dart_u3.c        Tue Aug 29 06:53:58 2006 -0400
@@ -55,10 +55,10 @@ static void u3_inv_all(void)
         dc.reg.dc_invtlb = 1;
         out_32(dart_ctl_reg, dc.dc_word);
 
-    do {
-        dc.dc_word = in_32(dart_ctl_reg);
-        r++;
-    } while ((dc.reg.dc_invtlb == 1) && (r < (1 << l)));
+        do {
+            dc.dc_word = in_32(dart_ctl_reg);
+            r++;
+        } while ((dc.reg.dc_invtlb == 1) && (r < (1 << l)));
 
         if (r == (1 << l)) {
             if (l < 4) {
diff -r 3e144748d36f -r 030a041bbe90 xen/arch/powerpc/external.c
--- a/xen/arch/powerpc/external.c       Mon Aug 28 17:28:55 2006 -0400
+++ b/xen/arch/powerpc/external.c       Tue Aug 29 06:53:58 2006 -0400
@@ -175,8 +175,7 @@ void init_IRQ(void)
 
 void ack_APIC_irq(void)
 {
-    printk("%s: EOI the whole MPIC?\n", __func__);
-    for (;;);
+    panic("%s: EOI the whole MPIC?\n", __func__);
 }
 
 void ack_bad_irq(unsigned int irq)
diff -r 3e144748d36f -r 030a041bbe90 xen/arch/powerpc/papr/tce.c
--- a/xen/arch/powerpc/papr/tce.c       Mon Aug 28 17:28:55 2006 -0400
+++ b/xen/arch/powerpc/papr/tce.c       Tue Aug 29 06:53:58 2006 -0400
@@ -47,7 +47,7 @@ static void h_put_tce(struct cpu_user_re
         regs->gprs[3] = H_Success;
     }
 }
-    
+
 static void h_get_tce(struct cpu_user_regs *regs)
 {
     u32 liobn = regs->gprs[4];
@@ -57,7 +57,7 @@ static void h_get_tce(struct cpu_user_re
     printk("%s: liobn: 0x%x ioba: 0x%lx \n", __func__, liobn, ioba);
 #endif
     regs->gprs[3] = H_Function;
-    for(;;) ;
+    BUG();
 }
 
 static void h_stuff_tce(struct cpu_user_regs *regs)
@@ -76,7 +76,7 @@ static void h_stuff_tce(struct cpu_user_
             count);
 #endif
     regs->gprs[3] = H_Function;
-    for(;;);
+    BUG();
 }
    
 __init_papr_hcall(H_PUT_TCE, h_put_tce);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog