[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-3.0.3-testing] [XEND] Check for and fail on non-existent floppy-drive file when starting HVM guest.



# HG changeset patch
# User kfraser@xxxxxxxxxxxxxxxxxxxxx
# Date 1160900366 -3600
# Node ID e321f036f6032af7128b59904a7cc3ae723b8d58
# Parent  edcd3a25a2bdae510d91edc7f1bfdb54f429c762
[XEND] Check for and fail on non-existent floppy-drive file when starting HVM 
guest.

The qemu device model hangs when a non-existent floppy file is passed
via 'fda' or 'fdb'. The attached patch checks whether the floppy file
exists and raises an error if it does not.

Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>
---
 tools/python/xen/xend/image.py |    5 +++++
 1 files changed, 5 insertions(+)

diff -r edcd3a25a2bd -r e321f036f603 tools/python/xen/xend/image.py
--- a/tools/python/xen/xend/image.py    Sun Oct 15 09:15:51 2006 +0100
+++ b/tools/python/xen/xend/image.py    Sun Oct 15 09:19:26 2006 +0100
@@ -312,6 +312,11 @@ class HVMImageHandler(ImageHandler):
                 if v:
                     ret.append("-%s" % a)
                     ret.append("%s" % v)
+
+            if a in ['fda', 'fdb' ]:
+                if v:
+                    if not os.path.isfile(v):
+                        raise VmError("Floppy file %s does not exist." % v)
             log.debug("args: %s, val: %s" % (a,v))
 
         # Handle disk/network related options

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.