[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] There is a somewhat trivial issue with XendCheckpoint.py right now in



# HG changeset patch
# User Ewan Mellor <ewan@xxxxxxxxxxxxx>
# Node ID bc14f1e1961abe28911dd043605e808ad98cc0c2
# Parent  0c0ef61de06b523fa44f67d97de01def87306e1d
There is a somewhat trivial issue with XendCheckpoint.py right now in
that it logs everything written to stderr by xc_save and xc_restore as
errors whereas in fact the vast majority of this output is
information/debug (and all actual errors are marked by the string ERROR:
at the start of the message) -- this is confusing to folks looking at
the logs and makes automated log analysis tricky.

Fix is to scan for the ERROR: string and log anything without it using
log.info instead.

Signed-off by: Simon Graham <Simon.Graham@xxxxxxxxxxx>
---
 tools/python/xen/xend/XendCheckpoint.py |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletion(-)

diff -r 0c0ef61de06b -r bc14f1e1961a tools/python/xen/xend/XendCheckpoint.py
--- a/tools/python/xen/xend/XendCheckpoint.py   Tue Nov 21 10:16:58 2006 +0000
+++ b/tools/python/xen/xend/XendCheckpoint.py   Tue Nov 21 10:19:01 2006 +0000
@@ -234,4 +234,9 @@ def slurp(infile):
         if line == "":
             break
         else:
-            log.error('%s', line.strip())
+            line = line.strip()
+            m = re.match(r"^ERROR: (.*)", line)
+            if m is None:
+                log.info('%s', line)
+            else:
+                log.error('%s', m.group(1))

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.