[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] xend: Don't allow migrate with assigned PCI devs.



# HG changeset patch
# User Keir Fraser <keir@xxxxxxxxxxxxx>
# Date 1183324213 -3600
# Node ID 2cdf8fef8d93311e38f1bbe928b05ddc4ee954d9
# Parent  ab95b9764b203d6876714694c1f98f34328574f3
xend: Don't allow migrate with assigned PCI devs.

This can potentially cause a whole machine crash, which I think has
been seen in the wild.  The case in the wild was caused by xendomains
auto-resuming domains on reboot, so it wasn't even operator error.

There's no sane way to migrate or suspend domains with PCI devs,
so I disallow it completely.

Signed-off-by: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
---
 tools/python/xen/xend/server/pciif.py |    3 +++
 1 files changed, 3 insertions(+)

diff -r ab95b9764b20 -r 2cdf8fef8d93 tools/python/xen/xend/server/pciif.py
--- a/tools/python/xen/xend/server/pciif.py     Fri Jun 29 14:38:18 2007 +0100
+++ b/tools/python/xen/xend/server/pciif.py     Sun Jul 01 22:10:13 2007 +0100
@@ -185,3 +185,6 @@ class PciController(DevController):
 
     def waitForBackend(self,devid):
         return (0, "ok - no hotplug")
+
+    def migrate(self, config, network, dst, step, domName):
+        raise XendError('Migration not permitted with assigned PCI device.')

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.