[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] xm: Fix control characters causing xm tests to fail.

# HG changeset patch
# User kfraser@xxxxxxxxxxxxxxxxxxxxx
# Date 1186404135 -3600
# Node ID 11b70c3d2194237f63a4301ec1fc2572283c0a6b
# Parent  c2d4efc2c8f9c091e24688adc18732863d615afa
xm: Fix control characters causing xm tests to fail.

On my FC7 installation some of the test in the xm test suite fail for
no apparent reason. The problem is that the python 'readline' module
puts out control characters that confuse code that parses the output
of some of the xm commands that are being run. The readline module
dumps those characters upon import. The attached patch works around
this problem.

Here's what I get in out.txt when doing 'python 2>&1 | tee out.txt'
and 'import readline' on the python command line:

Python 2.5 (r25:51908, Apr 10 2007, 10:29:13)
[GCC 4.1.2 20070403 (Red Hat 4.1.2-8)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
[[?1034h>>> >>>

The characters before the '>>>' above are those printed by that
version of 'readline' and remain invisible on the screen but appear in
the file and confuse the xm test suite parser.

Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>
 tools/python/xen/xm/main.py |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r c2d4efc2c8f9 -r 11b70c3d2194 tools/python/xen/xm/main.py
--- a/tools/python/xen/xm/main.py       Mon Aug 06 13:39:20 2007 +0100
+++ b/tools/python/xen/xm/main.py       Mon Aug 06 13:42:15 2007 +0100
@@ -25,7 +25,6 @@ import cmd
 import cmd
 import os
 import pprint
-import readline
 import shlex
 import sys
 import re
@@ -616,6 +615,7 @@ class Shell(cmd.Cmd):
     def preloop(self):
+        import readline
         readline.set_completer_delims(' ')
     def default(self, line):

Xen-changelog mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.