[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] x86 hvm: Another clarifying comment in the HVM address translation emulation.



# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1219171527 -3600
# Node ID a864ba2f0aa511dd42d213271b2829e6d12e1e17
# Parent  504e5334f1a2f8ff1ba53deec7475371c52ad29a
x86 hvm: Another clarifying comment in the HVM address translation emulation.
Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
---
 xen/arch/x86/hvm/emulate.c |    4 ++++
 1 files changed, 4 insertions(+)

diff -r 504e5334f1a2 -r a864ba2f0aa5 xen/arch/x86/hvm/emulate.c
--- a/xen/arch/x86/hvm/emulate.c        Tue Aug 19 18:52:04 2008 +0100
+++ b/xen/arch/x86/hvm/emulate.c        Tue Aug 19 19:45:27 2008 +0100
@@ -311,6 +311,10 @@ static int hvmemul_virtual_to_linear(
 
     if ( (hvmemul_ctxt->ctxt.regs->eflags & X86_EFLAGS_DF) && (*reps > 1) )
     {
+        /*
+         * x86_emulate() clips the repetition count to ensure we don't wrap
+         * the effective-address index register. Hence this assertion holds.
+         */
         ASSERT(offset >= ((*reps - 1) * bytes_per_rep));
         okay = hvm_virtual_to_linear_addr(
             seg, reg, offset - (*reps - 1) * bytes_per_rep,

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.