[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] x86: Time rendezvous function does not need to disable/enable IRQs.



# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1219669422 -3600
# Node ID 95f1dc27e1822e6d7e1838708dbf344f85e5adcd
# Parent  2ec019301ad8a16d776cb4eb9fedcc596aa39732
x86: Time rendezvous function does not need to disable/enable IRQs.
Since rendezvous happens within the IPI handler, no need to specify
'wait' to on_each_cpu().

Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
---
 xen/arch/x86/time.c |    6 +-----
 1 files changed, 1 insertion(+), 5 deletions(-)

diff -r 2ec019301ad8 -r 95f1dc27e182 xen/arch/x86/time.c
--- a/xen/arch/x86/time.c       Thu Aug 21 15:18:05 2008 +0100
+++ b/xen/arch/x86/time.c       Mon Aug 25 14:03:42 2008 +0100
@@ -1004,8 +1004,6 @@ static void time_calibration_rendezvous(
     struct cpu_calibration *c = &this_cpu(cpu_calibration);
     struct calibration_rendezvous *r = _r;
 
-    local_irq_disable();
-
     if ( smp_processor_id() == 0 )
     {
         while ( atomic_read(&r->nr_cpus) != (total_cpus - 1) )
@@ -1024,8 +1022,6 @@ static void time_calibration_rendezvous(
     c->stime_local_stamp = get_s_time();
     c->stime_master_stamp = r->master_stime;
 
-    local_irq_enable();
-
     /* Callback in softirq context as soon as possible. */
     set_timer(&c->softirq_callback, c->stime_local_stamp);
 }
@@ -1036,7 +1032,7 @@ static void time_calibration(void *unuse
         .nr_cpus = ATOMIC_INIT(0)
     };
 
-    on_each_cpu(time_calibration_rendezvous, &r, 0, 1);
+    on_each_cpu(time_calibration_rendezvous, &r, 0, 0);
 }
 
 void init_percpu_time(void)

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.