[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] x86 hvm: Remove the extra IS_PRIV_FOR() checks I added to do_hvm_op().



# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1239198192 -3600
# Node ID f9c8c6b0897274ffb682b259b794dde07cb2d8a5
# Parent  eddb0f09fdaff66ce3822699385dc8a01100bad2
x86 hvm: Remove the extra IS_PRIV_FOR() checks I added to do_hvm_op().
Actually this is already done by rcu_lock_target_domain_by_id(). Oops.

Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
---
 xen/arch/x86/hvm/hvm.c |   16 ----------------
 1 files changed, 16 deletions(-)

diff -r eddb0f09fdaf -r f9c8c6b08972 xen/arch/x86/hvm/hvm.c
--- a/xen/arch/x86/hvm/hvm.c    Wed Apr 08 14:06:37 2009 +0100
+++ b/xen/arch/x86/hvm/hvm.c    Wed Apr 08 14:43:12 2009 +0100
@@ -2439,10 +2439,6 @@ long do_hvm_op(unsigned long op, XEN_GUE
         if ( rc != 0 )
             return rc;
 
-        rc = -EPERM;
-        if ( (curr_d != d) && !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail;
-
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
             goto param_fail;
@@ -2621,10 +2617,6 @@ long do_hvm_op(unsigned long op, XEN_GUE
         if ( rc != 0 )
             return rc;
 
-        rc = -EPERM;
-        if ( !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail2;
-
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
             goto param_fail2;
@@ -2662,10 +2654,6 @@ long do_hvm_op(unsigned long op, XEN_GUE
         rc = rcu_lock_target_domain_by_id(a.domid, &d);
         if ( rc != 0 )
             return rc;
-
-        rc = -EPERM;
-        if ( !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail3;
 
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
@@ -2722,10 +2710,6 @@ long do_hvm_op(unsigned long op, XEN_GUE
         rc = rcu_lock_target_domain_by_id(a.domid, &d);
         if ( rc != 0 )
             return rc;
-
-        rc = -EPERM;
-        if ( !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail4;
 
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.