[Xen-changelog] [xen-3.4-testing] x86: Remove redundant logic for mp_register gsi.

["Xen patchbot-3.4-testing" <patchbot-3.4-testing@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1261481847 0
# Node ID fc6ca854775c70d502aa0c9ad0dcfc07977e0ea9
# Parent  608ebc959c359fb43e10a84121f68995191b078c
x86: Remove redundant logic for mp_register gsi.

For xen's irq and gsi, they are identity mapped, and doesn't
need to record the irq and gsi mapping in this array, in addition
the mapping maybe not correct, since dom0 may not figure the GSI
from 16 on.

Signed-off-by: Xiantao Zhang <xiantao.zhang@xxxxxxxxx>
xen-unstable changeset:   20509:b9ef03f18b5f
xen-unstable date:        Thu Nov 26 11:35:27 2009 +0000
---
 xen/arch/x86/mpparse.c |   40 +---------------------------------------
 1 files changed, 1 insertion(+), 39 deletions(-)

diff -r 608ebc959c35 -r fc6ca854775c xen/arch/x86/mpparse.c
--- a/xen/arch/x86/mpparse.c    Tue Dec 22 11:37:01 2009 +0000
+++ b/xen/arch/x86/mpparse.c    Tue Dec 22 11:37:27 2009 +0000
@@ -1057,20 +1057,16 @@ void __init mp_config_acpi_legacy_irqs (
        }
 }
 
-#define MAX_GSI_NUM    4096
-
 int mp_register_gsi (u32 gsi, int triggering, int polarity)
 {
        int                     ioapic = -1;
        int                     ioapic_pin = 0;
        int                     idx, bit = 0;
-       static int              pci_irq = 16;
        /*
         * Mapping between Global System Interrups, which
         * represent all possible interrupts, and IRQs
         * assigned to actual devices.
         */
-       static int              gsi_to_irq[MAX_GSI_NUM];
 
 #ifdef CONFIG_ACPI_BUS
        /* Don't set up the ACPI SCI because it's already set up */
@@ -1110,42 +1106,8 @@ int mp_register_gsi (u32 gsi, int trigge
 
        mp_ioapic_routing[ioapic].pin_programmed[idx] |= (1<<bit);
 
-       if (triggering == ACPI_LEVEL_SENSITIVE) {
-               /*
-                * For PCI devices assign IRQs in order, avoiding gaps
-                * due to unused I/O APIC pins.
-                */
-               int irq = gsi;
-               if (gsi < MAX_GSI_NUM) {
-                       /*
-                        * Retain the VIA chipset work-around (gsi > 15), but
-                        * avoid a problem where the 8254 timer (IRQ0) is setup
-                        * via an override (so it's not on pin 0 of the ioapic),
-                        * and at the same time, the pin 0 interrupt is a PCI
-                        * type.  The gsi > 15 test could cause these two pins
-                        * to be shared as IRQ0, and they are not shareable.
-                        * So test for this condition, and if necessary, avoid
-                        * the pin collision.
-                        */
-                       if (gsi > 15 || (gsi == 0 && !timer_uses_ioapic_pin_0))
-                               gsi = pci_irq++;
-#ifdef CONFIG_ACPI_BUS
-                       /*
-                        * Don't assign IRQ used by ACPI SCI
-                        */
-                       if (gsi == acpi_fadt.sci_int)
-                               gsi = pci_irq++;
-#endif
-                       gsi_to_irq[irq] = gsi;
-               } else {
-                       printk(KERN_ERR "GSI %u is too high\n", gsi);
-                       return -E2BIG;
-               }
-       }
-
        return io_apic_set_pci_routing(ioapic, ioapic_pin, gsi,
-                   triggering == ACPI_EDGE_SENSITIVE ? 0 : 1,
-                   polarity == ACPI_ACTIVE_HIGH ? 0 : 1);
+                   triggering, polarity);
 }
 
 #endif /* CONFIG_X86_IO_APIC */

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog