[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] libxenlight: initialize domid to -1 in domain_create



# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1262951316 0
# Node ID 182883d9acbe9a0b508eb5f1d0b406d76456f1ae
# Parent  b35974051d7e6b41b0f829452306d9eb45340dd2
libxenlight: initialize domid to -1 in domain_create

prevent call site that doesn't check return values to try to do
operation on domain 0.
instead they use domid -1, which is unlikely to exist.

Signed-off-by: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>
---
 tools/libxl/libxl.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r b35974051d7e -r 182883d9acbe tools/libxl/libxl.c
--- a/tools/libxl/libxl.c       Fri Jan 08 11:48:02 2010 +0000
+++ b/tools/libxl/libxl.c       Fri Jan 08 11:48:36 2010 +0000
@@ -99,7 +99,7 @@ int libxl_domain_make(struct libxl_ctx *
 
     flags = info->hvm ? XEN_DOMCTL_CDF_hvm_guest : 0;
     flags |= info->hap ? XEN_DOMCTL_CDF_hap : 0;
-    *domid = 0;
+    *domid = -1;
 
     /* Ultimately, handle is an array of 16 uint8_t, same as uuid */
     memcpy(handle, info->uuid, sizeof(xen_domain_handle_t));

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.