[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] Simplify continue_hypercall_on_cpu() now that it runs in vcpu context.



# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1271671634 -3600
# Node ID 6bf069a423183f5b8e7301f94e64cbe71458b5ee
# Parent  ac9293787beb2af3f310cd80b575da4b8d426dbc
Simplify continue_hypercall_on_cpu() now that it runs in vcpu context.

We do not need to take so much care over putting the original vcpu to
sleep, as it will not be spinning on progress of the idle vcpu.

Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
---
 xen/common/domain.c |   15 ++-------------
 1 files changed, 2 insertions(+), 13 deletions(-)

diff -r ac9293787beb -r 6bf069a42318 xen/common/domain.c
--- a/xen/common/domain.c       Mon Apr 19 10:12:41 2010 +0100
+++ b/xen/common/domain.c       Mon Apr 19 11:07:14 2010 +0100
@@ -919,19 +919,8 @@ static void continue_hypercall_tasklet_h
     struct migrate_info *info = (struct migrate_info *)_info;
     struct vcpu *v = info->vcpu;
 
-    /*
-     * Wait for vcpu to be entirely descheduled. We re-schedule ourselves
-     * meanwhile to allow other work to be done (e.g., descheduling the vcpu!).
-     */
-    BUG_ON(vcpu_runnable(v));
-    if ( v->is_running )
-    {
-        tasklet_schedule(&v->continue_hypercall_tasklet);
-        return;
-    }
-
-    /* Once descheduled, we need to gain access to its register state. */
-    sync_vcpu_execstate(v);
+    /* Wait for vcpu to sleep so that we can access its register state. */
+    vcpu_sleep_sync(v);
 
     this_cpu(continue_info) = info;
     return_reg(v) = (info->cpu == smp_processor_id())

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.