[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] x86: When failing smp_callin() properly clean up before halting.



# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1274305768 -3600
# Node ID 8114ea8495f07172077501af4af7755ea8e8b1d4
# Parent  b127760a4725041734f13092196970fbc1a002e0
x86: When failing smp_callin() properly clean up before halting.

In particular we must clear_local_APIC() else LAPIC NMI watchdog will
continue to fire and use a stack which no longer exists.

Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
---
 xen/arch/x86/smpboot.c |    2 ++
 1 files changed, 2 insertions(+)

diff -r b127760a4725 -r 8114ea8495f0 xen/arch/x86/smpboot.c
--- a/xen/arch/x86/smpboot.c    Wed May 19 21:14:57 2010 +0100
+++ b/xen/arch/x86/smpboot.c    Wed May 19 22:49:28 2010 +0100
@@ -164,6 +164,8 @@ void smp_callin(void)
         extern void (*dead_idle) (void);
         printk("CPU%d: Failed to initialise HVM. Not coming online.\n", cpu);
         cpu_error = rc;
+        clear_local_APIC();
+        spin_debug_enable();
         cpu_exit_clear(cpu);
         (*dead_idle)();
     }

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.