[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen-4.0-testing] x86: return value of domain_pirq_to_irq() is signed
# HG changeset patch # User Keir Fraser <keir.fraser@xxxxxxxxxx> # Date 1276867445 -3600 # Node ID 3c3210e1e8590ef642811a6b773f3281f854edb7 # Parent ba2c0eecaf7f0df5266e3d6c0f3736da3335ecae x86: return value of domain_pirq_to_irq() is signed That value can, for forcibly unbound PIRQs, validly be negative, and for the respective check to catch those cases (and prevent using these negative values as array index), the respective variables must be of signed type. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx> xen-unstable changeset: 21620:b0f7f710f512 xen-unstable date: Tue Jun 15 13:21:03 2010 +0100 --- xen/arch/x86/irq.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -r ba2c0eecaf7f -r 3c3210e1e859 xen/arch/x86/irq.c --- a/xen/arch/x86/irq.c Tue Jun 15 11:31:43 2010 +0100 +++ b/xen/arch/x86/irq.c Fri Jun 18 14:24:05 2010 +0100 @@ -879,7 +879,7 @@ struct irq_desc *domain_spin_lock_irq_de struct irq_desc *domain_spin_lock_irq_desc( struct domain *d, int pirq, unsigned long *pflags) { - unsigned int irq; + int irq; unsigned long flags; struct irq_desc *desc; @@ -1046,7 +1046,7 @@ static int pirq_acktype(struct domain *d static int pirq_acktype(struct domain *d, int pirq) { struct irq_desc *desc; - unsigned int irq; + int irq; irq = domain_pirq_to_irq(d, pirq); if ( irq <= 0 ) _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |