[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] Without this we leak an fd on each domain shutdown and eventually run



# HG changeset patch
# User Stefano Stabellini <sstabellini@xxxxxxxxxxxxx>
# Date 1279538484 -3600
# Node ID 9ccd024065c591071a22616fb00b854e2836ed33
# Parent  3e5baecab949193a297ac51e337db21d8449817d
Without this we leak an fd on each domain shutdown and eventually run
out of file descriptors meaning new the console of new domains are not
logged.

Seems to have been accidentally removed in 16638:28921e83000b.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 tools/console/daemon/io.c |    5 +++++
 1 files changed, 5 insertions(+)

diff -r 3e5baecab949 -r 9ccd024065c5 tools/console/daemon/io.c
--- a/tools/console/daemon/io.c Mon Jul 19 12:20:41 2010 +0100
+++ b/tools/console/daemon/io.c Mon Jul 19 12:21:24 2010 +0100
@@ -747,6 +747,11 @@ static void cleanup_domain(struct domain
 {
        domain_close_tty(d);
 
+       if (d->log_fd != -1) {
+               close(d->log_fd);
+               d->log_fd = -1;
+       }
+
        free(d->buffer.data);
        d->buffer.data = NULL;
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.