[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] libxl: libxl_device_console.build_state is const



# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1282227661 -3600
# Node ID d2f576d5cff5acc6dc2fa360cef7fa6199536bee
# Parent  fa82b0540e8c97178a0d98d5ecc068e1bbab55be
libxl: libxl_device_console.build_state is const

This field always refers to a libxl_domain_build_state structure which
is managed already by the caller, therefore it is incorrect to free it
as part of libxl_device_console_destroy.

(arguably this field should be a copy of, not a reference too, the original)

[PATCH 06 of 16 of
 libxl: autogenerate type definitions and destructor functions]

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 tools/libxl/libxl.idl |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r fa82b0540e8c -r d2f576d5cff5 tools/libxl/libxl.idl
--- a/tools/libxl/libxl.idl     Thu Aug 19 15:20:22 2010 +0100
+++ b/tools/libxl/libxl.idl     Thu Aug 19 15:21:01 2010 +0100
@@ -195,7 +195,7 @@ libxl_device_console = Struct("device_co
     ("domid", domid),
     ("devid", integer),
     ("consback", libxl_console_consback),
-    ("build_state", Reference(libxl_domain_build_state)),
+    ("build_state", Reference(libxl_domain_build_state), True),
     ("output", string),
     ])
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.