[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] x86 p2m: Fix comment regarding mfn_valid().



# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1283332599 -3600
# Node ID 2c2b177f8b711092572f70c90ff067745074099a
# Parent  73b131807d87df9b6c3b657dfcf9bdbcc3a27b1b
x86 p2m: Fix comment regarding mfn_valid().

MMIO pages are not always above max_page (e.g., >=4GB system with MMIO
in the RAM hole below 4GB).

Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
---
 xen/arch/x86/mm/p2m.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r 73b131807d87 -r 2c2b177f8b71 xen/arch/x86/mm/p2m.c
--- a/xen/arch/x86/mm/p2m.c     Wed Sep 01 09:48:52 2010 +0100
+++ b/xen/arch/x86/mm/p2m.c     Wed Sep 01 10:16:39 2010 +0100
@@ -2621,7 +2621,7 @@ clear_mmio_p2m_entry(struct p2m_domain *
 
     mfn = gfn_to_mfn(p2m, gfn, &t);
 
-    /* Do not use mfn_valid() here as MMIO pages are always above max_page */
+    /* Do not use mfn_valid() here as it will usually fail for MMIO pages. */
     if ( (INVALID_MFN == mfn_x(mfn)) || (t != p2m_mmio_direct) )
     {
         gdprintk(XENLOG_ERR,

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.