[Xen-changelog] [xen-unstable] libxl: Fix NULL deref in libxl_ctx_free()

[Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
# Date 1283882717 -3600
# Node ID fc00d97c84a31de160e31cb3e276ee346ff29aa7
# Parent  af3d0b44ebdc8878c100ecb8402a09ccb03b1f03
libxl: Fix NULL deref in libxl_ctx_free()

xc_interface_close() will de-reference a NULL handle, check for this
condition in libxl_ctx_free() before calling.

Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 tools/libxl/libxl.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r af3d0b44ebdc -r fc00d97c84a3 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c       Tue Sep 07 19:04:39 2010 +0100
+++ b/tools/libxl/libxl.c       Tue Sep 07 19:05:17 2010 +0100
@@ -67,7 +67,7 @@ int libxl_ctx_init(libxl_ctx *ctx, int v
 
 int libxl_ctx_free(libxl_ctx *ctx)
 {
-    xc_interface_close(ctx->xch);
+    if (ctx->xch) xc_interface_close(ctx->xch);
     libxl_version_info_destroy(&ctx->version_info);
     if (ctx->xsh) xs_daemon_close(ctx->xsh); 
     return 0;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog