[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] xl: don't leak a lot of memory in forked process in domain_create



# HG changeset patch
# User Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
# Date 1284140989 -3600
# Node ID 5ad5ba05e3aff5ed78bb225755850d760866b178
# Parent  8caf87c7a017d69ecb74fbb9aa506b02db938ea2
xl: don't leak a lot of memory in forked process in domain_create

A goto statement skips over freeing data structures for no good reason.
It's not a real issue since the next step is to exit() but this cleans
up output of valgrind so that other leaks and errors can be spotted.

Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 tools/libxl/xl_cmdimpl.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r 8caf87c7a017 -r 5ad5ba05e3af tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c  Fri Sep 10 18:49:00 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c  Fri Sep 10 18:49:49 2010 +0100
@@ -1511,7 +1511,7 @@ start:
                 goto error_out;
             }
             ret = domid;
-            goto waitpid_out;
+            goto out;
         }
 
         rc = libxl_ctx_postfork(&ctx);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.