[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] stubdom: Fix stubdom-dm using "grep" improperly



# HG changeset patch
# User John Weekes <lists.xen@xxxxxxxxxxxxxxxxxx>
# Date 1294764161 0
# Node ID 6852e3e7ef58bd1db90af1edeb42c6cf24318fc8
# Parent  7674b78a6c0d2208ae3b47e0cd5d52fc567b7555
stubdom: Fix stubdom-dm using "grep" improperly

stubdom-dm uses "grep" on "xm list" output to determine whether it is
already running. The existing behavior is to use "grep $domname-dm" but
this will result in a false-positive in the case of another domU running
whose name ends with the full new name; for instance, if "abctest-dm" is
running, a new "test-dm" will spin forever, waiting for it the end.

Any easy fix is to have it use "grep -w" instead of "grep", searching
for the whole word only.

It also might be worth considering a switch to "xl list" from "xm list",
here and in other places.

Signed-off-by: John Weekes <lists.xen@xxxxxxxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 stubdom/stubdom-dm |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r 7674b78a6c0d -r 6852e3e7ef58 stubdom/stubdom-dm
--- a/stubdom/stubdom-dm        Tue Jan 11 16:31:47 2011 +0000
+++ b/stubdom/stubdom-dm        Tue Jan 11 16:42:41 2011 +0000
@@ -91,7 +91,7 @@ trap term SIGHUP
 ############
 # stubdomain
 # Wait for any previous stubdom to terminate
-while xm list | grep $domname-dm
+while xm list | grep -w $domname-dm
 do
        sleep 1
 done

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.