[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen-unstable] x86: Fix pirq teardown on domain destruction.
# HG changeset patch # User Wei Gang <gang.wei@xxxxxxxxx> # Date 1296032052 0 # Node ID e7f44fb4ecc378665d2cfd2353693a9f1a00cd72 # Parent 4785c70c2b6d1d8ab4dab3aa7431ef32d0c56362 x86: Fix pirq teardown on domain destruction. The privilege check in unmap_domain_pirq() fails since the teardown completes in RCU (idle domain) context. We can remove the check since it is covered in physdev_op() already, which is the only potentially unprivileged caller. Signed-off-by: Wei Gang <gang.wei@xxxxxxxxx> --- xen/arch/x86/irq.c | 3 --- 1 files changed, 3 deletions(-) diff -r 4785c70c2b6d -r e7f44fb4ecc3 xen/arch/x86/irq.c --- a/xen/arch/x86/irq.c Wed Jan 26 08:45:40 2011 +0000 +++ b/xen/arch/x86/irq.c Wed Jan 26 08:54:12 2011 +0000 @@ -1567,9 +1567,6 @@ int unmap_domain_pirq(struct domain *d, if ( (pirq < 0) || (pirq >= d->nr_pirqs) ) return -EINVAL; - if ( !IS_PRIV_FOR(current->domain, d) ) - return -EINVAL; - ASSERT(spin_is_locked(&pcidevs_lock)); ASSERT(spin_is_locked(&d->event_lock)); _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |