[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [linux-2.6.18-xen] xen/blkfront: fix data size for xenbus_gather in connect()

# HG changeset patch
# User Jan Beulich <jbeulich@xxxxxxxxxx>
# Date 1304931739 -3600
# Node ID c896d26c6b7c70bc82e353e7d02579fdd26af2f6
# Parent  3cb58d4cdd0b0f0ecd411804f79511cf055ec718
xen/blkfront: fix data size for xenbus_gather in connect()

From: Marek Marczykowski <marmarek@xxxxxxxxxxxx>

barrier variable is int, not long. This overflow caused another
variable override: "err" (in PV code) and "binfo" (in xenlinux code -
drivers/xen/blkfront/blkfront.c). The latter caused incorrect device
flags (RO/removable etc).

Signed-off-by: Marek Marczykowski <marmarek@xxxxxxxxxxxx>
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

diff -r 3cb58d4cdd0b -r c896d26c6b7c drivers/xen/blkfront/blkfront.c
--- a/drivers/xen/blkfront/blkfront.c   Tue Apr 05 12:42:02 2011 +0100
+++ b/drivers/xen/blkfront/blkfront.c   Mon May 09 10:02:19 2011 +0100
@@ -360,7 +360,7 @@
        err = xenbus_gather(XBT_NIL, info->xbdev->otherend,
-                           "feature-barrier", "%lu", &info->feature_barrier,
+                           "feature-barrier", "%d", &info->feature_barrier,
        if (err)
                info->feature_barrier = 0;

Xen-changelog mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.