[Xen-changelog] [xen-unstable] libxl: make it possible to disable vnc

[Xen patchbot-unstable <patchbot@xxxxxxx>]

# HG changeset patch
# User Zhou Peng <zhoupeng@xxxxxxxxxxxxxxx>
# Date 1305904273 -3600
# Node ID a3118a249ea37cdabbf943507a86d995944ac4ce
# Parent  d65c1f12b214c8cef48322b7ac0cf4892e96d89c
libxl: make it possible to disable vnc

tools/libxl/libxl__build_device_model_args_new/old: The condition is
so rigorous that user has no chance to disable the vnc,
considering what has been done in parse_config_data() by default,
which is not resonable with vnc option in vm-cfg file.

I think, If user explicitly set "vnc=0", vnc should be disabled.
User should have the chance to only use sdl, other remote
display(spice) and even nothing.

Signed-off-by: Zhou Peng <zhoupeng@xxxxxxxxxxxxxxx>
Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---


diff -r d65c1f12b214 -r a3118a249ea3 tools/libxl/libxl_dm.c
--- a/tools/libxl/libxl_dm.c    Fri May 20 15:39:07 2011 +0100
+++ b/tools/libxl/libxl_dm.c    Fri May 20 16:11:13 2011 +0100
@@ -97,7 +97,7 @@
     if (info->dom_name)
         flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
 
-    if (info->vnc || info->vncdisplay || info->vnclisten || info->vncunused) {
+    if (info->vnc) {
         char *vncarg;
         if (info->vncdisplay) {
             if (info->vnclisten && strchr(info->vnclisten, ':') == NULL) {
@@ -252,7 +252,7 @@
     if (info->dom_name) {
         flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
     }
-    if (info->vnc || info->vncdisplay || info->vnclisten || info->vncunused) {
+    if (info->vnc) {
         int display = 0;
         const char *listen = "127.0.0.1";
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog