[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-4.1-testing] libxc: obtain correct length of p2m during core dumping

# HG changeset patch
# User Markus Gross <gross@xxxxxxxxxxxxx>
# Date 1306570180 -3600
# Node ID d0feff6ff44cfc5a20cc0e2adced7f151f49872b
# Parent  41fcee15368a12c45506d8c0b206d2fb77626378
libxc: obtain correct length of p2m during core dumping

while implementing core dumping functionality for the libxl driver
of libvirt, I discovered an issue with mapping pages of a pv guest.

After dumping the core of a pv guest the domain was not cleared up
properly and some pages were not unmapped. This issue is similar
to the one reported here:

In xc_domain_dumpcore_via_callback in the file xc_core.c the function
xc_core_arch_map_p2m is called to map P2M_FL_ENTRIES pages to the
variable p2m.
But to unmap the pages later, the dinfo->p2m_size has to be set
This was not done, instead a variable named p2m_size was set.
This way P2M_FL_ENTRIES was always zero and the pages were left

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
xen-unstable changeset:   23374:8bd7b5e98f2a
xen-unstable date:        Tue May 24 15:00:16 2011 +0100

diff -r 41fcee15368a -r d0feff6ff44c tools/libxc/xc_core.c
--- a/tools/libxc/xc_core.c     Sat May 28 09:08:21 2011 +0100
+++ b/tools/libxc/xc_core.c     Sat May 28 09:09:40 2011 +0100
@@ -468,7 +468,6 @@
     int auto_translated_physmap;
     xen_pfn_t *p2m = NULL;
-    unsigned long p2m_size = 0;
     struct xen_dumpcore_p2m *p2m_array = NULL;
     uint64_t *pfn_array = NULL;
@@ -569,7 +568,7 @@
         sts = xc_core_arch_map_p2m(xch, dinfo->guest_width, &info, live_shinfo,
-                                   &p2m, &p2m_size);
+                                   &p2m, &dinfo->p2m_size);
         if ( sts != 0 )
             goto out;

Xen-changelog mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.