[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] libxl: correct allocation size in libxl_list_nics



# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1317224144 -3600
# Node ID 72e3391299e42e35400f21bf5d9d54137275b8a6
# Parent  8877da7ba3a43dc39870bd6defa8d195b87fbaa8
libxl: correct allocation size in libxl_list_nics

The function returns a list of libxl_nicinfo not libxl_device_nic.

Causes memory corruption on free.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---


diff -r 8877da7ba3a4 -r 72e3391299e4 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c       Wed Sep 28 16:34:00 2011 +0100
+++ b/tools/libxl/libxl.c       Wed Sep 28 16:35:44 2011 +0100
@@ -1296,7 +1296,7 @@
                            libxl__sprintf(&gc, "%s/device/vif", dompath), 
&nb_nics);
     if (!l)
         goto err;
-    nics = res = calloc(nb_nics, sizeof (libxl_device_nic));
+    nics = res = calloc(nb_nics, sizeof (libxl_nicinfo));
     if (!res)
         goto err;
     for (*nb = nb_nics; nb_nics > 0; --nb_nics, ++l, ++nics) {

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.