[Xen-changelog] [xen-3.4-testing] x86/HPET: bug fix

[Xen patchbot-3.4-testing <patchbot@xxxxxxx>]

# HG changeset patch
# User Keith Coleman <keith.coleman@xxxxxxxxxxxxx>
# Date 1317422233 14400
# Node ID 6d780b6d41319890cbd4390d7427c9cb909a0ee1
# Parent  90a184da7b92039b6ee4642351fa898c64e92aa4
x86/HPET: bug fix

This patch fixes a bug where an unitialized lock lookedlock looked like
a locked lock. Now we always call spin_lock_init on the legacy variable.

Thanks for Andrew Coopers suggestion.

Xen-unstable changeset 23031:5263151fba9b contains the fix along with
many other cleanups.

Signed-off-by: Keith Coleman <keith.coleman@xxxxxxxxxxxxx>
Signed-off-by: Jeff Bester <jeff.bester@xxxxxxxxxxxxx>
Committed-by: Keith Coleman <keith.coleman@xxxxxxxxxxxxx>
---


diff -r 90a184da7b92 -r 6d780b6d4131 xen/arch/x86/hpet.c
--- a/xen/arch/x86/hpet.c       Tue Aug 30 03:05:09 2011 -0400
+++ b/xen/arch/x86/hpet.c       Fri Sep 30 18:37:13 2011 -0400
@@ -531,6 +531,8 @@
     u32 hpet_id, cfg;
     int i;
 
+    spin_lock_init(&legacy_hpet_event.lock);
+
     hpet_rate = hpet_setup();
     if ( hpet_rate == 0 )
         return;
@@ -596,7 +598,6 @@
     legacy_hpet_event.event_handler = handle_hpet_broadcast;
     legacy_hpet_event.idx = 0;
     legacy_hpet_event.flags = 0;
-    spin_lock_init(&legacy_hpet_event.lock);
 
     for_each_cpu(i)
         per_cpu(cpu_bc_channel, i) = &legacy_hpet_event;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog