[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen-4.1-testing] VT-d: fix off-by-one error in RMRR validation
# HG changeset patch # User Jan Beulich <jbeulich@xxxxxxxx> # Date 1317655872 -3600 # Node ID 8e6b081e80442ab2c868f47f5dcdb6beec3df601 # Parent 2a0cd93f7ed9666ac60baa19c69bd89cad63c79e VT-d: fix off-by-one error in RMRR validation (base_addr,end_addr) is an inclusive range, and hence there shouldn't be a subtraction of 1 in the second invocation of page_is_ram_type(). For RMRRs covering a single page that actually resulted in the immediately preceding page to get checked (which could have resulted in a false warning). Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> xen-unstable changeset: 23868:28147fd781af xen-unstable date: Thu Sep 22 18:32:34 2011 +0100 --- diff -r 2a0cd93f7ed9 -r 8e6b081e8044 xen/drivers/passthrough/vtd/dmar.c --- a/xen/drivers/passthrough/vtd/dmar.c Mon Oct 03 16:29:52 2011 +0100 +++ b/xen/drivers/passthrough/vtd/dmar.c Mon Oct 03 16:31:12 2011 +0100 @@ -519,7 +519,7 @@ * inform the user */ if ( (!page_is_ram_type(paddr_to_pfn(base_addr), RAM_TYPE_RESERVED)) || - (!page_is_ram_type(paddr_to_pfn(end_addr) - 1, RAM_TYPE_RESERVED)) ) + (!page_is_ram_type(paddr_to_pfn(end_addr), RAM_TYPE_RESERVED)) ) { dprintk(XENLOG_WARNING VTDPREFIX, " RMRR address range not in reserved memory " _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |