[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-4.1-testing] Return -EINVAL when trying to kick/kill a nonexistent domain watchdog



# HG changeset patch
# User Keir Fraser <keir@xxxxxxx>
# Date 1319729041 -3600
# Node ID c33e15835e33a6ba4fde0c1d853cd2a7e3c0664e
# Parent  849bf4ab5fe0b9006d59965edc2de630d2976118
Return -EINVAL when trying to kick/kill a nonexistent domain watchdog

... to be more in-line with the NR_DOMAIN_WATCHDOG_TIMERS check at the
top of domain_watchdog(), and also to follow the
timer_(delete|settime)
POSIX API's EINVAL return value.

Signed-off-by: Laszlo Ersek <lersek@xxxxxxxxxx>

Also, replace EEXIST with ENOSPC when failing to allocate a new
domain watchdog.

Signed-off-by: Keir Fraser <keir@xxxxxxx>

Committed-by: Keir Fraser <keir@xxxxxxx>
xen-unstable changeset:   23963:7cfd5bb3b9f9
xen-unstable date:        Fri Oct 14 18:08:04 2011 +0100
---


diff -r 849bf4ab5fe0 -r c33e15835e33 xen/common/schedule.c
--- a/xen/common/schedule.c     Thu Oct 27 16:22:53 2011 +0100
+++ b/xen/common/schedule.c     Thu Oct 27 16:24:01 2011 +0100
@@ -762,14 +762,14 @@
             break;
         }
         spin_unlock(&d->watchdog_lock);
-        return id == NR_DOMAIN_WATCHDOG_TIMERS ? -EEXIST : id + 1;
+        return id == NR_DOMAIN_WATCHDOG_TIMERS ? -ENOSPC : id + 1;
     }
 
     id -= 1;
     if ( !test_bit(id, &d->watchdog_inuse_map) )
     {
         spin_unlock(&d->watchdog_lock);
-        return -EEXIST;
+        return -EINVAL;
     }
 
     if ( timeout == 0 )

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.