[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] xenstored: Fix processing of zero-length messages



# HG changeset patch
# User Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
# Date 1320171917 0
# Node ID 45025966f7d1e556d1c9085279c392f50c92a71e
# Parent  f60911281a1bb1e77ef257be629065102be21a80
xenstored: Fix processing of zero-length messages

When a message with zero length is sent to xenstore, the body of the
message was not processed until the socket or ring had more data to
read; this will cause deadlocks if the requestor is waiting on a
response to continue.

Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---


diff -r f60911281a1b -r 45025966f7d1 tools/xenstore/xenstored_core.c
--- a/tools/xenstore/xenstored_core.c   Tue Oct 18 13:36:43 2011 +0100
+++ b/tools/xenstore/xenstored_core.c   Tue Nov 01 18:25:17 2011 +0000
@@ -1297,7 +1297,6 @@
                        goto bad_client;
                in->used = 0;
                in->inhdr = false;
-               return;
        }
 
        bytes = conn->read(conn, in->buffer + in->used,

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.