[Xen-changelog] [xen-unstable] x86/IRQ: create_irq() should call assign_irq_vector()

[Xen patchbot-unstable <patchbot@xxxxxxx>]

# HG changeset patch
# User Jan Beulich <jbeulich@xxxxxxxx>
# Date 1320769711 -3600
# Node ID c47cebd7a83f6760d58b0899e6ec154fde47d350
# Parent  be8daf78856a605ec8f8df11ff13c325dc4bc70f
x86/IRQ: create_irq() should call assign_irq_vector()

... rather than __assign_irq_vector(), to ensure desc->affinity gets
initialized properly.

This at once eliminates the need to forward-declare the latter function.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Keir Fraser <keir@xxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---


diff -r be8daf78856a -r c47cebd7a83f xen/arch/x86/irq.c
--- a/xen/arch/x86/irq.c        Tue Nov 08 13:01:41 2011 +0000
+++ b/xen/arch/x86/irq.c        Tue Nov 08 17:28:31 2011 +0100
@@ -25,7 +25,6 @@
 #include <public/physdev.h>
 
 static void parse_irq_vector_map_param(char *s);
-static int __assign_irq_vector(int irq, struct irq_desc *, const cpumask_t *);
 
 /* opt_noirqbalance: If true, software IRQ balancing/affinity is disabled. */
 bool_t __read_mostly opt_noirqbalance = 0;
@@ -156,7 +155,6 @@
  */
 int create_irq(void)
 {
-    unsigned long flags;
     int irq, ret;
     struct irq_desc *desc;
 
@@ -172,11 +170,7 @@
 
     ret = init_one_irq_desc(desc);
     if (!ret)
-    {
-        spin_lock_irqsave(&vector_lock, flags);
-        ret = __assign_irq_vector(irq, desc, TARGET_CPUS);
-        spin_unlock_irqrestore(&vector_lock, flags);
-    }
+        ret = assign_irq_vector(irq);
     if (ret < 0)
     {
         desc->arch.used = IRQ_UNUSED;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog