[Xen-changelog] [xen-unstable] libxl: propagate error from tap_ctl_spawn.

[Xen patchbot-unstable <patchbot@xxxxxxx>]

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1322502160 0
# Node ID a2cb7ed6d0a2ee5aecb3a988750ce9c8d8b718ee
# Parent  52b6b80e847f893aa1e8dbb00b16941b57ff1f6b
libxl: propagate error from tap_ctl_spawn.

Failure here means that a disk will not be correctly setup. I briefly
scanned tools/blktap2/control.c for other goto constructs which did not
set their err variable but didn't see any others.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---


diff -r 52b6b80e847f -r a2cb7ed6d0a2 tools/blktap2/control/tap-ctl-create.c
--- a/tools/blktap2/control/tap-ctl-create.c    Mon Nov 28 17:42:06 2011 +0000
+++ b/tools/blktap2/control/tap-ctl-create.c    Mon Nov 28 17:42:40 2011 +0000
@@ -44,8 +44,10 @@
                return err;
 
        id = tap_ctl_spawn();
-       if (id < 0)
+       if (id < 0) {
+               err = id;
                goto destroy;
+       }
 
        err = tap_ctl_attach(id, minor);
        if (err)

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog