[Xen-changelog] [xen-unstable] Tools: When passing no bitmap for the shadow log dirty bitmap clean up, we should not get EFAULT

[Xen patchbot-unstable <patchbot@xxxxxxx>]

# HG changeset patch
# User Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
# Date 1322749034 0
# Node ID 039f79e2c5dcb1e73b2b938f85594542a943c829
# Parent  20c1c0ff9677999a096ab8525e661738d6653484
Tools: When passing no bitmap for the shadow log dirty bitmap clean up, we 
should not get EFAULT

This is due to a stale check for guest_handle_null in the hypervisor,
which doesn't necessarily work with the hypercall buffers.

Signed-off-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Tim Deegan <tim@xxxxxxx>
---


diff -r 20c1c0ff9677 -r 039f79e2c5dc tools/libxc/xc_domain.c
--- a/tools/libxc/xc_domain.c   Thu Dec 01 12:24:06 2011 +0100
+++ b/tools/libxc/xc_domain.c   Thu Dec 01 14:17:14 2011 +0000
@@ -430,6 +430,8 @@
     DECLARE_DOMCTL;
     DECLARE_HYPERCALL_BUFFER_ARGUMENT(dirty_bitmap);
 
+    memset(&domctl, 0, sizeof(domctl));
+
     domctl.cmd = XEN_DOMCTL_shadow_op;
     domctl.domain = (domid_t)domid;
     domctl.u.shadow_op.op     = sop;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog