[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] tools/blktap2: fix build errors caused by Werror in


  • To: xen-changelog@xxxxxxxxxxxxxxxxxxx
  • From: Xen patchbot-unstable <patchbot@xxxxxxx>
  • Date: Mon, 14 May 2012 16:32:17 +0000
  • Delivery-date: Mon, 14 May 2012 16:32:22 +0000
  • List-id: "Change log for Mercurial \(receive only\)" <xen-changelog.lists.xen.org>

# HG changeset patch
# User Olaf Hering <olaf@xxxxxxxxx>
# Date 1336645145 -3600
# Node ID ca02580986d2e78a6ccb90dae66f7cbd1ad8058c
# Parent  54da0329e259c11b63afe3312c9fa6cc1cb7cc9d
tools/blktap2: fix build errors caused by Werror in
vhd_journal_write_entry

-O2 -Wall -Werror triggers these warnings:

libvhd-journal.c: In function 'vhd_journal_write_entry':
libvhd-journal.c:335: warning: statement with no effect

Really return the error from vhd_journal_write() to caller.

v2:
 - simplify the patch by just adding the missing return statement

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
Committed-by: Keir Fraser <keir@xxxxxxx>
---


diff -r 54da0329e259 -r ca02580986d2 tools/blktap2/vhd/lib/libvhd-journal.c
--- a/tools/blktap2/vhd/lib/libvhd-journal.c    Thu May 10 11:04:32 2012 +0100
+++ b/tools/blktap2/vhd/lib/libvhd-journal.c    Thu May 10 11:19:05 2012 +0100
@@ -332,7 +332,7 @@ vhd_journal_write_entry(vhd_journal_t *j
 
        err = vhd_journal_write(j, &e, sizeof(vhd_journal_entry_t));
        if (err)
-               err;
+               return err;
 
        return 0;
 }

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.