[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen-unstable] libxc: Do not segfault if (e.g.) switch_qemu_logdirty fails
# HG changeset patch # User Ian Jackson <ian.jackson@xxxxxxxxxxxxx> # Date 1340905399 -3600 # Node ID a31a5064552a8762a0dec25307dd4dd46992abeb # Parent b366b34bc159560e4bd8c12eeb3717b5dcb5fe9a libxc: Do not segfault if (e.g.) switch_qemu_logdirty fails In xc_domain_save the local variable `ob' is initialised to NULL. There are then various startup actions. Some of these `goto out' on failure; for example the call to callbacks->switch_qemu_logdirty on l.978. However, out is used both by success and error paths. So it attempts (l.2043) to flush the current output buffer. If ob has not yet been assigned a non-NULL value, this segfaults. So make the call to outbuf_flush conditional on ob. Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> Committed-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> --- diff -r b366b34bc159 -r a31a5064552a tools/libxc/xc_domain_save.c --- a/tools/libxc/xc_domain_save.c Thu Jun 28 18:43:19 2012 +0100 +++ b/tools/libxc/xc_domain_save.c Thu Jun 28 18:43:19 2012 +0100 @@ -2040,7 +2040,7 @@ int xc_domain_save(xc_interface *xch, in } /* Flush last write and discard cache for file. */ - if ( outbuf_flush(xch, ob, io_fd) < 0 ) { + if ( ob && outbuf_flush(xch, ob, io_fd) < 0 ) { PERROR("Error when flushing output buffer"); rc = 1; } _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |