[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] x86/numa: Remove warning about small NUMA nodes


  • To: xen-changelog@xxxxxxxxxxxxxxxxxxx
  • From: Xen patchbot-unstable <patchbot@xxxxxxx>
  • Date: Thu, 19 Jul 2012 22:44:08 +0000
  • Delivery-date: Thu, 19 Jul 2012 22:44:19 +0000
  • List-id: "Change log for Mercurial \(receive only\)" <xen-changelog.lists.xen.org>

# HG changeset patch
# User Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
# Date 1342709248 -3600
# Node ID afc5fee8ae12df8936f4f52c11e2b32aa97ff72a
# Parent  8575d677b472c0849d05fc563157299c7455bd54
x86/numa: Remove warning about small NUMA nodes

This logic came with the other NUMA logic from Linux 2.6.16 in c/s
11893:f312c2d01d8b.  It appears that the Xen memory management
subsystem does not suffer from the expressed problems.  Furthermore,
NUMA nodes with no memory are now quite easy to find, and are not BIOS
bugs in the SRAT ACPI table.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Committed-by: Keir Fraser <keir@xxxxxxx>
---


diff -r 8575d677b472 -r afc5fee8ae12 xen/arch/x86/srat.c
--- a/xen/arch/x86/srat.c       Thu Jul 19 15:46:51 2012 +0100
+++ b/xen/arch/x86/srat.c       Thu Jul 19 15:47:28 2012 +0100
@@ -34,9 +34,6 @@ static int num_node_memblks;
 static struct node node_memblk_range[NR_NODE_MEMBLKS];
 static int memblk_nodeid[NR_NODE_MEMBLKS];
 
-/* Too small nodes confuse the VM badly. Usually they result
-   from BIOS bugs. */
-#define NODE_MIN_SIZE (4*1024*1024)
 
 static int node_to_pxm(int n);
 
@@ -454,10 +451,6 @@ int __init acpi_scan_nodes(u64 start, u6
                        printk(KERN_WARNING "SRAT: Node %u has no memory. "
                               "BIOS Bug or mis-configured hardware?\n", i);
 
-               else if (size < NODE_MIN_SIZE)
-                       printk(KERN_WARNING "SRAT: Node %u has only %"PRIu64
-                              " bytes of memory. BIOS Bug?\n", i, size);
-
                setup_node_bootmem(i, nodes[i].start, nodes[i].end);
        }
        for (i = 0; i < nr_cpu_ids; i++) {

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.