[Xen-changelog] [xen-unstable] VT-d: make remap_entry_to_msi_msg() return consistent message

[Xen patchbot-unstable <patchbot@xxxxxxx>]

# HG changeset patch
# User Jan Beulich <jbeulich@xxxxxxxx>
# Date 1349335705 -7200
# Node ID 72d89cc43c72848be9bf49da9a87729ed8f48433
# Parent  761def707575b154fa29e29d7962048352165c0d
VT-d: make remap_entry_to_msi_msg() return consistent message

During debugging of another problem I found that in x2APIC mode, the
destination field of the low address value wasn't passed back
correctly. While this is benign in most cases (as the value isn't being
used anywhere), it can be confusing (and misguiding) when printing the
value read or when comparing it to the one previously passed into the
inverse function.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Keir Fraser <keir@xxxxxxx>
---


diff -r 761def707575 -r 72d89cc43c72 xen/drivers/passthrough/vtd/intremap.c
--- a/xen/drivers/passthrough/vtd/intremap.c    Thu Oct 04 09:05:24 2012 +0200
+++ b/xen/drivers/passthrough/vtd/intremap.c    Thu Oct 04 09:28:25 2012 +0200
@@ -521,8 +521,8 @@ static int remap_entry_to_msi_msg(
     if ( x2apic_enabled )
         msg->dest32 = iremap_entry->lo.dst;
     else
-        msg->address_lo |=
-            ((iremap_entry->lo.dst >> 8) & 0xff ) << MSI_ADDR_DEST_ID_SHIFT;
+        msg->dest32 = (iremap_entry->lo.dst >> 8) & 0xff;
+    msg->address_lo |= (msg->dest32 & 0xff) << MSI_ADDR_DEST_ID_SHIFT;
 
     msg->data =
         MSI_DATA_TRIGGER_EDGE |

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog