[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] xen: remove XEN_GUEST_HANDLE(ulong)


  • To: xen-changelog@xxxxxxxxxxxxxxxxxxx
  • From: Xen patchbot-unstable <patchbot@xxxxxxx>
  • Date: Fri, 19 Oct 2012 22:11:14 +0000
  • Delivery-date: Fri, 19 Oct 2012 22:11:20 +0000
  • List-id: "Change log for Mercurial \(receive only\)" <xen-changelog.lists.xen.org>

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1350488634 -3600
# Node ID 5529b91bd2e441b71acf2aa95b94d29202e10bd2
# Parent  2a1083b1d0c24f943a1e0bca335fc11aabf6536e
xen: remove XEN_GUEST_HANDLE(ulong)

Having both this handle (always unsigned long) and
XEN_GUEST_HANDLE(xen_ulong_t) (unsigned long on x86 and explicit size
of ARM) is confusing and error prone.

Replace the two remaining uses of the ulong handle, in grant set and
x86 set_gdt hypercalls, with xen_ulong_t.

This correctly sizes the grant frame entry as 64 bit on ARM but
leaves it as unsigned long on x86 (therefore no intended change on
x86). Likewise in set_gdt there is no actual change.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Acked-by: Keir Fraser <keir@xxxxxxx>
Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---


diff -r 2a1083b1d0c2 -r 5529b91bd2e4 xen/arch/x86/mm.c
--- a/xen/arch/x86/mm.c Wed Oct 17 16:43:53 2012 +0100
+++ b/xen/arch/x86/mm.c Wed Oct 17 16:43:54 2012 +0100
@@ -4100,7 +4100,8 @@ long set_gdt(struct vcpu *v,
 }
 
 
-long do_set_gdt(XEN_GUEST_HANDLE_PARAM(ulong) frame_list, unsigned int entries)
+long do_set_gdt(XEN_GUEST_HANDLE_PARAM(xen_ulong_t) frame_list,
+                unsigned int entries)
 {
     int nr_pages = (entries + 511) / 512;
     unsigned long frames[16];
diff -r 2a1083b1d0c2 -r 5529b91bd2e4 xen/common/grant_table.c
--- a/xen/common/grant_table.c  Wed Oct 17 16:43:53 2012 +0100
+++ b/xen/common/grant_table.c  Wed Oct 17 16:43:54 2012 +0100
@@ -1322,7 +1322,7 @@ gnttab_setup_table(
     struct domain *d;
     struct grant_table *gt;
     int            i;
-    unsigned long  gmfn;
+    xen_pfn_t  gmfn;
 
     if ( count != 1 )
         return -EINVAL;
diff -r 2a1083b1d0c2 -r 5529b91bd2e4 xen/include/asm-x86/hypercall.h
--- a/xen/include/asm-x86/hypercall.h   Wed Oct 17 16:43:53 2012 +0100
+++ b/xen/include/asm-x86/hypercall.h   Wed Oct 17 16:43:54 2012 +0100
@@ -33,7 +33,7 @@ do_mmu_update(
 
 extern long
 do_set_gdt(
-    XEN_GUEST_HANDLE_PARAM(ulong) frame_list,
+    XEN_GUEST_HANDLE_PARAM(xen_ulong_t) frame_list,
     unsigned int entries);
 
 extern long
diff -r 2a1083b1d0c2 -r 5529b91bd2e4 xen/include/public/grant_table.h
--- a/xen/include/public/grant_table.h  Wed Oct 17 16:43:53 2012 +0100
+++ b/xen/include/public/grant_table.h  Wed Oct 17 16:43:54 2012 +0100
@@ -385,7 +385,7 @@ struct gnttab_setup_table {
     uint32_t nr_frames;
     /* OUT parameters. */
     int16_t  status;              /* => enum grant_status */
-    XEN_GUEST_HANDLE(ulong) frame_list;
+    XEN_GUEST_HANDLE(xen_pfn_t) frame_list;
 };
 typedef struct gnttab_setup_table gnttab_setup_table_t;
 DEFINE_XEN_GUEST_HANDLE(gnttab_setup_table_t);
diff -r 2a1083b1d0c2 -r 5529b91bd2e4 xen/include/public/xen.h
--- a/xen/include/public/xen.h  Wed Oct 17 16:43:53 2012 +0100
+++ b/xen/include/public/xen.h  Wed Oct 17 16:43:54 2012 +0100
@@ -43,8 +43,6 @@ DEFINE_XEN_GUEST_HANDLE(char);
 __DEFINE_XEN_GUEST_HANDLE(uchar, unsigned char);
 DEFINE_XEN_GUEST_HANDLE(int);
 __DEFINE_XEN_GUEST_HANDLE(uint,  unsigned int);
-DEFINE_XEN_GUEST_HANDLE(long);
-__DEFINE_XEN_GUEST_HANDLE(ulong, unsigned long);
 DEFINE_XEN_GUEST_HANDLE(void);
 
 DEFINE_XEN_GUEST_HANDLE(uint64_t);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.