[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen-unstable] libxl: fix vfb related assertion problem when starting pv-domU


  • To: xen-changelog@xxxxxxxxxxxxxxxxxxx
  • From: Xen patchbot-unstable <patchbot@xxxxxxx>
  • Date: Tue, 13 Nov 2012 16:22:11 +0000
  • Delivery-date: Tue, 13 Nov 2012 16:22:18 +0000
  • List-id: "Change log for Mercurial \(receive only\)" <xen-changelog.lists.xen.org>

# HG changeset patch
# User Ronny Hegewald <ronny.hegewald@xxxxxxxxx>
# Date 1352805557 0
# Node ID 8b93ac0c93f3fb8a140b4688ba71841ac927d4e3
# Parent  170d45f7a2ebde462743d98c77a1d10ee0f51a29
libxl: fix vfb related assertion problem when starting pv-domU

When a config-file for a pv-domU has a vfb section with a vnc=0
option then a "xl create" for that domU crashes with the message

xl: libxl.c:252: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)'
failed.

and the domU hangs early in the start.

This patch fixes the cause of the assertion and let the domU start
normally.

This problem exists since xen 4.2.

Signed-off-by: Ronny Hegewald <Ronny.Hegewald@xxxxxxxxx>
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---


diff -r 170d45f7a2eb -r 8b93ac0c93f3 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c       Tue Nov 13 10:47:00 2012 +0000
+++ b/tools/libxl/libxl.c       Tue Nov 13 11:19:17 2012 +0000
@@ -3186,6 +3186,8 @@ int libxl__device_vfb_setdefault(libxl__
         }
 
         libxl_defbool_setdefault(&vfb->vnc.findunused, true);
+    } else {
+        libxl_defbool_setdefault(&vfb->vnc.findunused, false);
     }
 
     libxl_defbool_setdefault(&vfb->sdl.enable, false);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.