[Xen-changelog] [qemu-upstream-unstable] qapi: handle visitor->type_size() in QapiDeallocVisitor

[patchbot@xxxxxxx]

commit 0c26f2eca40d6c65ea9edc62a10e510dc7f65cc8
Author: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
Date:   Mon Nov 26 13:10:12 2012 +0100

    qapi: handle visitor->type_size() in QapiDeallocVisitor
    
    visit_type_size() requires either visitor->type_size() or
    visitor_uint64() to be implemented, otherwise a NULL function pointer is
    invoked.
    
    It is possible to trigger this crash as follows:
    
      $ qemu-system-x86_64 -netdev tap,sndbuf=0,id=netdev0 \
                           -device virtio-blk-pci,netdev=netdev0
    
    The 'sndbuf' option has type "size".
    
    Reviewed-by: Andreas Färber <afaerber@xxxxxxx>
    Reviewed-by: Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
    Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
    Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>
---
 qapi/qapi-dealloc-visitor.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c
index a154523..a07b171 100644
--- a/qapi/qapi-dealloc-visitor.c
+++ b/qapi/qapi-dealloc-visitor.c
@@ -132,6 +132,11 @@ static void qapi_dealloc_type_number(Visitor *v, double 
*obj, const char *name,
 {
 }
 
+static void qapi_dealloc_type_size(Visitor *v, size_t *obj, const char *name,
+                                   Error **errp)
+{
+}
+
 static void qapi_dealloc_type_enum(Visitor *v, int *obj, const char *strings[],
                                    const char *kind, const char *name,
                                    Error **errp)
@@ -164,6 +169,7 @@ QapiDeallocVisitor *qapi_dealloc_visitor_new(void)
     v->visitor.type_bool = qapi_dealloc_type_bool;
     v->visitor.type_str = qapi_dealloc_type_str;
     v->visitor.type_number = qapi_dealloc_type_number;
+    v->visitor.type_size = qapi_dealloc_type_size;
 
     QTAILQ_INIT(&v->stack);
 
--
generated by git-patchbot for /home/xen/git/qemu-upstream-unstable.git

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog