[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [qemu-upstream-unstable] iscsi: fix segfault in url parsing



commit 8da1e18b0cf46b6c95c88bbad1cc50d6dd1bef4b
Author: Peter Lieven <pl@xxxxxxxxx>
Date:   Thu Nov 15 15:42:06 2012 +0100

    iscsi: fix segfault in url parsing
    
    If an invalid URL is specified iscsi_get_error(iscsi) is called
    with iscsi == NULL.
    
    Signed-off-by: Peter Lieven <pl@xxxxxxx>
    Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
---
 block/iscsi.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/block/iscsi.c b/block/iscsi.c
index a6a819d..5cd8b49 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -947,8 +947,7 @@ static int iscsi_open(BlockDriverState *bs, const char 
*filename, int flags)
 
     iscsi_url = iscsi_parse_full_url(iscsi, filename);
     if (iscsi_url == NULL) {
-        error_report("Failed to parse URL : %s %s", filename,
-                     iscsi_get_error(iscsi));
+        error_report("Failed to parse URL : %s", filename);
         ret = -EINVAL;
         goto out;
     }
--
generated by git-patchbot for /home/xen/git/qemu-upstream-unstable.git

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.