[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [qemu-upstream-unstable] nbd-server-add: Fix the default for 'writable'



commit f3313d23a061648c99609a4c127ed13c820f831d
Author: Michal Privoznik <mprivozn@xxxxxxxxxx>
Date:   Wed Nov 28 11:46:39 2012 +0100

    nbd-server-add: Fix the default for 'writable'
    
    The documentation to this monitor command tells, that 'writable'
    argument is optional and defaults to false. However, the code sets
    true as the default. But since some applications may already been
    using this, it's safer to fix the code and not documentation which
    would break those applications.
    
    Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
    Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
---
 blockdev-nbd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/blockdev-nbd.c b/blockdev-nbd.c
index d1721a3..6b26bbf 100644
--- a/blockdev-nbd.c
+++ b/blockdev-nbd.c
@@ -99,7 +99,7 @@ void qmp_nbd_server_add(const char *device, bool 
has_writable, bool writable,
     }
 
     if (!has_writable) {
-        writable = true;
+        writable = false;
     }
     if (bdrv_is_read_only(bs)) {
         writable = false;
--
generated by git-patchbot for /home/xen/git/qemu-upstream-unstable.git

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.