[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [linux-2.6.18-xen] blkback: Don't trust the handle from the frontend
# HG changeset patch # User Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> # Date 1359370526 -3600 # Node ID d207555739095b1e4babed58bda341ffa5271dd4 # Parent feb110c9141c2efcdaa8cbc92268b8515771377d blkback: Don't trust the handle from the frontend The 'handle' is the device that the request is from. For the life-time of the ring we copy it from a request to a response so that the frontend is not surprised by it. But we do not need it - when we start processing I/Os we have our own 'struct phys_req' which has only most essential information about the request. In fact the 'vbd_translate' ends up over-writing the preq.dev with a value from the backend. This assignment of preq.dev with the 'handle' value is superfluous so lets not do it. Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> Committed-by: Jan Beulich <jbeulich@xxxxxxxx> --- diff -r feb110c9141c -r d20755573909 drivers/xen/blkback/blkback.c --- a/drivers/xen/blkback/blkback.c Fri Jan 18 12:47:29 2013 +0100 +++ b/drivers/xen/blkback/blkback.c Mon Jan 28 11:55:26 2013 +0100 @@ -440,7 +440,6 @@ static void dispatch_rw_block_io(blkif_t goto fail_response; } - preq.dev = req->handle; preq.sector_number = req->sector_number; preq.nr_sects = 0; _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |