[Xen-changelog] [linux-2.6.18-xen] pciback: rate limit error message from pciback_enable_msi()

[Xen patchbot-linux-2.6.18-xen <patchbot@xxxxxxx>]

# HG changeset patch
# User Jan Beulich <jbeulich@xxxxxxxx>
# Date 1360056344 -3600
# Node ID 4b8e7a5d4f89692bca6855ccad3ec5a71611c231
# Parent  d962d1681b10974cf6bcdc4240c904c712db3e62
pciback: rate limit error message from pciback_enable_msi()

... as being guest triggerable (e.g. by invoking XEN_PCI_OP_enable_msi
on a device not being MSI capable).

This is CVE-2013-0231 / XSA-43.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---


diff -r d962d1681b10 -r 4b8e7a5d4f89 
drivers/xen/pciback/conf_space_capability_msi.c
--- a/drivers/xen/pciback/conf_space_capability_msi.c   Tue Feb 05 10:23:47 
2013 +0100
+++ b/drivers/xen/pciback/conf_space_capability_msi.c   Tue Feb 05 10:25:44 
2013 +0100
@@ -11,13 +11,12 @@
 int pciback_enable_msi(struct pciback_device *pdev,
                struct pci_dev *dev, struct xen_pci_op *op)
 {
-       int otherend = pdev->xdev->otherend_id;
-       int status;
-
-       status = pci_enable_msi(dev);
+       int status = pci_enable_msi(dev);
 
        if (status) {
-               printk("error enable msi for guest %x status %x\n", otherend, 
status);
+               if (printk_ratelimit())
+                       printk("error enabling MSI for guest %u status %d\n",
+                              pdev->xdev->otherend_id, status);
                op->value = 0;
                return XEN_PCI_ERR_op_failed;
        }

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog