[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [qemu-xen-unstable] qemu-xen-trad/pt_msi_disable: do not clear all MSI flags

commit adf74189dd58014744a4b8c9d64407d629da5e2f
Author:     Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
AuthorDate: Mon Dec 10 12:43:33 2012 +0000
Commit:     Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
CommitDate: Fri Feb 22 18:06:21 2013 +0000

    qemu-xen-trad/pt_msi_disable: do not clear all MSI flags
    "qemu-xen-trad: fix msi_translate with PV event delivery" added a
    pt_msi_disable() call into pt_msgctrl_reg_write, clearing the MSI flags
    as a consequence. MSIs get enabled again soon after by calling
    However the MSI flags are only setup once in the pt_msgctrl_reg_init
    function, so from the QEMU point of view the device has lost some
    important properties, like for example PCI_MSI_FLAGS_64BIT.
    This patch fixes the bug by clearing only the MSI
    enabled/mapped/initialized flags in pt_msi_disable.
    Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
    Tested-by: G.R. <firemeteor@xxxxxxxxxxxxxxxxxxxxx>
    Xen-devel: http://marc.info/?l=xen-devel&m=135489879503075
 hw/pt-msi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/pt-msi.c b/hw/pt-msi.c
index 73f737d..b03b989 100644
--- a/hw/pt-msi.c
+++ b/hw/pt-msi.c
@@ -213,7 +213,7 @@ void pt_msi_disable(struct pt_dev *dev)
     /* clear msi info */
-    dev->msi->flags = 0;
+    dev->msi->flags &= ~(MSI_FLAG_UNINIT | PT_MSI_MAPPED | 
     dev->msi->pirq = -1;
     dev->msi_trans_en = 0;
generated by git-patchbot for /home/xen/git/qemu-xen-unstable.git

Xen-changelog mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.